mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.
Date Mon, 04 Dec 2017 18:35:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64104/#review192730
-----------------------------------------------------------




src/tests/health_check_tests.cpp
Lines 852-853 (original), 852-853 (patched)
<https://reviews.apache.org/r/64104/#comment270981>

    Nit: join lines.



src/tests/health_check_tests.cpp
Lines 1396-1398 (original), 1396-1398 (patched)
<https://reviews.apache.org/r/64104/#comment270982>

    Nit: remove now resolved TODO comment.



src/tests/health_check_tests.cpp
Lines 1489-1492 (original), 1489-1492 (patched)
<https://reviews.apache.org/r/64104/#comment270984>

    Nit: ditto.



src/tests/health_check_tests.cpp
Lines 1947-1948 (original), 1947-1948 (patched)
<https://reviews.apache.org/r/64104/#comment270985>

    Nit: join lines.



src/tests/health_check_tests.cpp
Lines 2224-2225 (original), 2224-2225 (patched)
<https://reviews.apache.org/r/64104/#comment270986>

    Nit: join lines.


- Andrew Schwartzmeyer


On Nov. 30, 2017, 9:18 a.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64104/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 9:18 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-6709
>     https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added dependency of curl to agent. Enabled most health check tests.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
>   src/tests/health_check_tests.cpp c0dcba265363f2149b217b189ee5a8e925e40ea1 
> 
> 
> Diff: https://reviews.apache.org/r/64104/diff/1/
> 
> 
> Testing
> -------
> 
> There are two health check tests which are not enabled yet, because they require the
IOSwitchboard to be ported first. We can't resolve MESOS-6709 quite yet until that is addressed.
The rest of the tests pass on both Linux/Windows, as mentioned in #64102
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message