mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.
Date Mon, 04 Dec 2017 21:19:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63341/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 1:19 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael
Park.


Changes
-------

Rebased.


Bugs: MESOS-5455
    https://issues.apache.org/jira/browse/MESOS-5455


Repository: mesos


Description
-------

This resolves MESOS-5455, and consolidates the `BUILD` variables into
one location.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 
  src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
  src/common/build.cpp 4192b89cbee1c9d7a75213f55b189565cd8a10f1 
  src/common/build_config.hpp.in ac7059ab2aa54011197b9e1a46f9d7fd39ac39c6 


Diff: https://reviews.apache.org/r/63341/diff/4/

Changes: https://reviews.apache.org/r/63341/diff/3-4/


Testing
-------

Checked the emitted `build_config.hpp` under various conditions; flags are set correctly (and
can still build of course).


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message