mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63342: Fixed CMake binary dependencies.
Date Mon, 04 Dec 2017 21:19:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63342/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 1:19 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael
Park.


Changes
-------

Rebased.


Bugs: MESOS-8035
    https://issues.apache.org/jira/browse/MESOS-8035


Repository: mesos


Description
-------

This resolves MESOS-8035 so that building just the `mesos-agent`, etc.
target should correctly build its runtime dependencies (such as the
containerizer, executor, etc.).


Diffs (updated)
-----

  src/local/CMakeLists.txt 5e5bee3b70b2407bd86d9e7ffe0d169346054942 
  src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924 
  src/tests/CMakeLists.txt 5e5202079c9798b91028e845490b747d4d1d0a66 


Diff: https://reviews.apache.org/r/63342/diff/4/

Changes: https://reviews.apache.org/r/63342/diff/3-4/


Testing
-------

Cleaned build folder, built just the `mesos-agent` target on Windows and Linux, verified it
could launch and connect to a master (built clean with just `--target mesos-master`. Launched
a simple task via Marathon to confirm end-to-end support.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message