mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.
Date Mon, 04 Dec 2017 21:27:30 GMT


> On Dec. 4, 2017, 1:26 p.m., Joseph Wu wrote:
> > You should mention in the commit description the slight modifications you made in
the code movement: All code source paths were updated to the new path (i.e. `java/src/org/apache/mesos/Executor.java`
-> `src/org/apache/mesos/Executor.java`).

Good point! Will fix when committing.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/#review192764
-----------------------------------------------------------


On Dec. 4, 2017, 1:19 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63340/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 1:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Java build code to `java/CMakeLists.txt`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63340/diff/3/
> 
> 
> Testing
> -------
> 
> Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries
Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use
the Java components).
> 
> Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message