mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.
Date Tue, 05 Dec 2017 00:13:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 4:13 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael
Park.


Changes
-------

Add updated test results. Re-verifying Java build on Windows.


Repository: mesos


Description
-------

Moved Java build code to `java/CMakeLists.txt`.


Diffs
-----

  src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
  src/java/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/63340/diff/3/


Testing (updated)
-------

Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries
Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use
the Java components).

Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.

Update: thought I was going crazy seeing these:

```
[  FAILED  ] 5 tests, listed below:
[  FAILED  ] ExamplesTest.JavaFramework
[  FAILED  ] ExamplesTest.JavaException
[  FAILED  ] ExamplesTest.JavaLog
[  FAILED  ] ExamplesTest.V0JavaFramework
[  FAILED  ] ExamplesTest.V1JavaFramework
```

but then remembered these are expected to fail as we still don't yet build the example java
JAR file.

```
# TODO(andschwa): Build the Example JAR.
set(EXAMPLE_JAR_SRC
  ../examples/java/TestExceptionFramework.java
  ../examples/java/TestExecutor.java
  ../examples/java/TestFramework.java
  ../examples/java/TestLog.java
  ../examples/java/TestMultipleExecutorsFramework.java
  ../examples/java/V1TestFramework.java)
```


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message