mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.
Date Tue, 05 Dec 2017 02:17:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64033/#review192804
-----------------------------------------------------------




src/exec/exec.cpp
Lines 350-359 (patched)
<https://reviews.apache.org/r/64033/#comment271094>

    hmm, wondering how is this even possible? We explicitly `link()` the executor's PID when
the executor registers with the agent. So all messages from the agent to the executor are
sent on a persistent connection.
    
    This means that the following can _only happen_ when the initial connection between the
agent and the executor broke and instead it did not use a non-persistent socket. We currently
don't do anything in the `exited()` function of the agent when an executor exits. We should
rather shutdown the executor if we notice that the connection breaks.


- Anand Mazumdar


On Dec. 4, 2017, 6:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64033/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
> 
> 
> Bugs: MESOS-8297
>     https://issues.apache.org/jira/browse/MESOS-8297
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered
> to a driver-based executor. Since these messages are not retried,
> without this patch an executor never starts a task and remains idle,
> ignoring kill task request. This patch ensures all built-in driver-
> based executors eventually shut down if kill task arrives before
> the task has been started.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f 
>   src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc 
>   src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 
> 
> 
> Diff: https://reviews.apache.org/r/64033/diff/4/
> 
> 
> Testing
> -------
> 
> make check on MacOS 10.11.6
> 
> Manual testing using modified "exec.cpp" that drops executor registration confirmation.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message