mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63631: Separated event visiting and consumption.
Date Tue, 05 Dec 2017 17:00:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63631/#review192879
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/event.hpp
Lines 91-127 (original), 103-144 (patched)
<https://reviews.apache.org/r/63631/#comment271214>

    I noticed that we have 2 types of messages:
      (1) copyable but not assignable
      (2) not copyable nor assignable
    
    I think we should make all of the message properly move-only. (e.g., the changes we made
to `HttpEvent`).
    For most of them we just need to remove the `const` on the members.



3rdparty/libprocess/include/process/event.hpp
Lines 114-117 (original), 126-129 (patched)
<https://reviews.apache.org/r/63631/#comment271209>

    This comment needs to be updated.



3rdparty/libprocess/include/process/event.hpp
Lines 155-158 (original), 178-181 (patched)
<https://reviews.apache.org/r/63631/#comment271210>

    Let's clean these up and pull them up and declare them `= delete;`.
    Here and below.


- Michael Park


On Dec. 4, 2017, 8:01 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63631/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 8:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This introduces `EventConsumer` interface, which add support of events
> with movable only data. This allows consumers to move data out of
> event, rather than copying it. This is required to implement movable
> only objects support in `defer` to guarantee that deferred functor is
> invoked only once, allowing deferred parameters to be moved into call.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 571ffb1ea5c4787f10c2f4dee249aadc8b904bc6

>   3rdparty/libprocess/include/process/process.hpp d88c2f241a04cac3ec2e1d9fd4b323643ad24ae4

>   3rdparty/libprocess/include/process/protobuf.hpp 08605db4aa7ae782f1e5a1f692db9d46f899f842

>   3rdparty/libprocess/include/process/run.hpp 46a182b2dd4ab7add6d6f547e83958b19fa2a0f2

>   3rdparty/libprocess/src/process.cpp 64bcce215d19558dd493e30e96ca16577fe0722a 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 2c6de626c3fdf5ebd3a7aa5793553215c42dd494

>   3rdparty/libprocess/src/tests/process_tests.cpp d1b30b0754c55fd765885ddcfe9f9f68ba509ac1

> 
> 
> Diff: https://reviews.apache.org/r/63631/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message