mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63971: Defined a module interface for translating volume profiles.
Date Wed, 06 Dec 2017 18:37:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63971/#review193013
-----------------------------------------------------------




include/mesos/resource_provider/volume_profile.hpp
Lines 34 (patched)
<https://reviews.apache.org/r/63971/#comment271487>

    This module is not limited to SLRP. It can be used by SERP in the future. I'd suggest
we remove the `Local` part in the commejnts.



include/mesos/resource_provider/volume_profile.hpp
Lines 49 (patched)
<https://reviews.apache.org/r/63971/#comment271486>

    Looks like we name modules using `XXXer` pattern. `VolumeProfile` might make people think
this is a volume profile, not a module to translate volume profiles and get volume profile
names.
    
    Suggest to use something like `VolumeProfileAdaptor`.



include/mesos/resource_provider/volume_profile.hpp
Lines 89-91 (patched)
<https://reviews.apache.org/r/63971/#comment271484>

    Instead of using a tuple, can we define a struct instead?



include/mesos/resource_provider/volume_profile.hpp
Lines 92 (patched)
<https://reviews.apache.org/r/63971/#comment271485>

    We chatted about having an ability to define a default profile. To support that, maybe
`profile` here needs to be Optional?


- Jie Yu


On Dec. 5, 2017, 10:06 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63971/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 10:06 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Bugs: MESOS-8251
>     https://issues.apache.org/jira/browse/MESOS-8251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This module is currently intended for use by the Storage Local
> Resource Provider (SLRP), but may be used by other components if
> those components use any of the affected Container Storage Interface
> (CSI) requests. The affected calls are listed in the module's comments.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87 
>   include/mesos/resource_provider/volume_profile.hpp PRE-CREATION 
>   include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a 
> 
> 
> Diff: https://reviews.apache.org/r/63971/diff/3/
> 
> 
> Testing
> -------
> 
> See end of chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message