mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64391: Fixed incorrect testing of existence of variables.
Date Wed, 06 Dec 2017 20:54:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64391/#review193042
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Dec. 6, 2017, 8:27 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64391/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 8:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The following was committed in response to a Javascript linter,
> but the corresponding change was incorrect.
> https://github.com/apache/mesos/commit/af8404e
> 
> Specifically:
> ```
> - page_size || $.error('Expecting page_size to be defined');
> - truncate_length || $.error('Expecting truncate_length to be defined');
> + if (page_size) {
> +     $.error('Expecting page_size to be defined')
> + }
> +
> + if (truncate_length) {
> +     $.error('Expecting truncate_length to be defined')
> + }
> ```
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/jquery.pailer.js 93ff04bac328d72a45317b2f15ccbc5e45c161d4

> 
> 
> Diff: https://reviews.apache.org/r/64391/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message