mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64454: Fixed a typo in a gpu test.
Date Fri, 08 Dec 2017 17:13:17 GMT


> On Dec. 8, 2017, 4:56 p.m., Benno Evers wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
> > Line 268 (original), 268 (patched)
> > <https://reviews.apache.org/r/64454/diff/1/?file=1911666#file1911666line268>
> >
> >     Since we're fixing this, actually only one of these should need the extra-long
waiting time, probably the second although I don't completely remember at which point in the
executor code path the image is fetched.

Dropping this issue because its covered in a later review in this chain.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64454/#review193257
-----------------------------------------------------------


On Dec. 8, 2017, 4:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64454/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 4:48 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5e40a940770cb45c9ac181b953a4e57e4b053445

> 
> 
> Diff: https://reviews.apache.org/r/64454/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/64456/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message