mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.
Date Sat, 09 Dec 2017 01:47:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64461/#review193302
-----------------------------------------------------------



Also, we need to update the tests or fix the library functions because sometimes we get short
paths like `ADMIN~1` vs `Administrator` depending on what Windows API we call. Causing stuff
like this:
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath


3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 354 (patched)
<https://reviews.apache.org/r/64461/#comment271864>

    Does this flag exist on older versions of Windows? You might need a `#ifndef X #define
X Y #endif` to get this to compile



3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
Lines 364 (patched)
<https://reviews.apache.org/r/64461/#comment271865>

    Could you point out where in the docs that say this mutex is required. I couldn't find
it.


- Akash Gupta


On Dec. 8, 2017, 9:18 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64461/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2017, 9:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8307
>     https://issues.apache.org/jira/browse/MESOS-8307
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some users are regrettably stuck on versions of Windows before this
> feature was added. If the `ALLOW_UNPRIVILEGED` flag is unsupported, the
> creation of the symlink will fail with `ERROR_INVALID_PARAMETER`. In
> this case, we try again without the flag (which will require
> administrative privileges, and so need to be guarded by a mutex) for
> these older systems.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 158f44550327c63fb416052ad9978b55e4efe36b

> 
> 
> Diff: https://reviews.apache.org/r/64461/diff/1/
> 
> 
> Testing
> -------
> 
> Still works on Windows 10 Fall Creator's Update, needs to be tested to prove working
on legacy systems.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message