mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 64570: Windows: Temporarily fixed the docker executor.
Date Wed, 13 Dec 2017 22:21:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64570/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
-------

The docker executor was setting its `PATH` through
`os::host_default_path()`, so it could not find the docker executable.
Now, on Windows, the docker executor inherits the environment variables
from the agent. Further investigation needs to be done on why `PATH`
was this way and if the docker executor could simply inherit the
agent's environment.


Diffs
-----

  src/slave/containerizer/docker.cpp 229891da1b23ca1a5cf2b6b15cd16de6fa0d8240 


Diff: https://reviews.apache.org/r/64570/diff/1/


Testing
-------

See https://reviews.apache.org/r/64386/


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message