mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64620: Fixed `os::chown` error message.
Date Thu, 14 Dec 2017 19:02:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64620/#review193828
-----------------------------------------------------------


Ship it!




> The getpwnam() and getpwuid() functions return a pointer to a passwd structure, or NULL
if the matching entry is
> not found or an error occurs.  If an error occurs, errno is set appropriately.  If  one
 wants  to  check  errno
> after the call, it should be set to zero before the call.

- Andrew Schwartzmeyer


On Dec. 14, 2017, 10:58 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64620/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 10:58 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> getpwnam(3) only sets `errno` if there is an error. To detect
> the (most common) case where the user account is successfully
> not found, we need to clear `errno` and verify that it is
> still clear on failure.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/chown.hpp e2214acbd726e8f84480e97f01ca240096a75877

> 
> 
> Diff: https://reviews.apache.org/r/64620/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message