mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.
Date Thu, 14 Dec 2017 19:35:12 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 14, 2017, 11:35 a.m.)

Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and Joseph Wu.

Bugs: MESOS-8307

Repository: mesos


Some users are regrettably stuck on versions of Windows before this
feature was added. If the `ALLOW_UNPRIVILEGED` flag is unsupported, the
creation of the symlink will fail with `ERROR_INVALID_PARAMETER`. In
this case, we try again without the flag (which will require
administrative privileges, and so need to be guarded by a mutex) for
these older systems.


  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 158f44550327c63fb416052ad9978b55e4efe36b


Testing (updated)

~Still works on Windows 10 Fall Creator's Update, needs to be tested to prove working on legacy

Tested on Windows Server 2016. _Other, unrelated stout-tests fail on the old systems because
of different reasons regarding username expansion._ Symlinks work again.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message