mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.
Date Thu, 14 Dec 2017 19:35:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64461/
-----------------------------------------------------------

(Updated Dec. 14, 2017, 11:35 a.m.)


Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and Joseph Wu.


Bugs: MESOS-8307
    https://issues.apache.org/jira/browse/MESOS-8307


Repository: mesos


Description
-------

Some users are regrettably stuck on versions of Windows before this
feature was added. If the `ALLOW_UNPRIVILEGED` flag is unsupported, the
creation of the symlink will fail with `ERROR_INVALID_PARAMETER`. In
this case, we try again without the flag (which will require
administrative privileges, and so need to be guarded by a mutex) for
these older systems.


Diffs
-----

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 158f44550327c63fb416052ad9978b55e4efe36b



Diff: https://reviews.apache.org/r/64461/diff/2/


Testing (updated)
-------

~Still works on Windows 10 Fall Creator's Update, needs to be tested to prove working on legacy
systems.~

Tested on Windows Server 2016. _Other, unrelated stout-tests fail on the old systems because
of different reasons regarding username expansion._ Symlinks work again.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message