mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64699: Added a test to ensure quota headroom is maintained.
Date Tue, 19 Dec 2017 05:12:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64699/#review194126
-----------------------------------------------------------


Ship it!




Very nice!


src/tests/hierarchical_allocator_tests.cpp
Lines 1763 (patched)
<https://reviews.apache.org/r/64699/#comment272858>

    WhenReservationsExceedQuota



src/tests/hierarchical_allocator_tests.cpp
Lines 1805 (patched)
<https://reviews.apache.org/r/64699/#comment272859>

    are no


- Benjamin Mahler


On Dec. 19, 2017, 3:02 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64699/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 3:02 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8339
>     https://issues.apache.org/jira/browse/MESOS-8339
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that quota headroom is correctly
> maintained when some roles have more reservations than
> their quota. We need to ensure that one role's excessive
> reservaiton is not counted towards another role's quota
> headroom.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 4127d0591e4abffa74720fecccb1999c1a808534

> 
> 
> Diff: https://reviews.apache.org/r/64699/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message