mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62161: Update boost version.
Date Tue, 19 Dec 2017 19:09:35 GMT


> On Nov. 7, 2017, 7:14 a.m., Benjamin Bannier wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 1-2 (original), 1-2 (patched)
> > <https://reviews.apache.org/r/62161/diff/3/?file=1832079#file1832079line1>
> >
> >     Let's please make sure to add this bundle to https://github.com/mesos/3rdparty
before landing this patch. Otherwise we break cmake builds with `REBUNDLED=OFF`.
> 
> Benno Evers wrote:
>     https://github.com/mesos/3rdparty/pull/14

Added.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/#review190302
-----------------------------------------------------------


On Oct. 6, 2017, 7:02 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62161/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 7:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update boost version.
> 
> 
> Diffs
> -----
> 
>   3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab 
>   3rdparty/boost-1.65.0.tar.gz PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 958629642 
>   3rdparty/versions.am 82d66be7d 
> 
> 
> Diff: https://reviews.apache.org/r/62161/diff/4/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 0001-Update-boost-version.patch
>   https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message