mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform.
Date Tue, 19 Dec 2017 19:38:38 GMT


> On Dec. 19, 2017, 11:35 a.m., Andrew Schwartzmeyer wrote:
> > Ship It!

For context: this change is necessary to support using the fetcher for `https` downloads on
Windows. While we previously built cURL with OpenSSL support, on Windows this does not come
with a ca-certificate bundle, and so it would refuse to download because it (correctly) could
not verify the TLS connection.

By upgrading cURL, we were able to switch to "WinSSL" aka SChannel, which is the native Windows
crypto implementation, and thus has access to the OS's certificates. This fixes fetching over
TLS connections, and can be enabled uncondtionally, regardless of the use of OpenSSL for libevent.

Because we upgraded cURL, we had to update our build due to significant changes to the upstsream
build system (i.e. the debug build of the executable is now called `curl-d.exe`, etc.).


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64720/#review194170
-----------------------------------------------------------


On Dec. 19, 2017, 11:33 a.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64720/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Along with this, a number of changes were made:
> 
> 1. Debug versions of cURL build with libcurl-d and curl-d.exe.
>    Modified build system to handle these issues.
> 2. cURL is built to make use of SChannel (native Windows encryption)
>    by default. This means we no longer need to build Mesos with
>    cmake flag -DENABLE_SSL=ON, cURL isn't sensitive to that.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt d9f52e20f2aa3bdc1544a9db70857aba02598439 
>   3rdparty/cmake/Versions.cmake 13bd33ddc0dacc6dc8c4ac7e460e39fdb2c1327d 
> 
> 
> Diff: https://reviews.apache.org/r/64720/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message