mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64737: Added validation / normalized resources for storage-related operations.
Date Wed, 20 Dec 2017 02:09:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64737/#review194203
-----------------------------------------------------------


Ship it!




Looks good, but I was a little puzzled, did we just forget these cases or were they added
by others? Maybe add that context to the description for posterity?

- Benjamin Mahler


On Dec. 20, 2017, 12:49 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64737/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 12:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4 
> 
> 
> Diff: https://reviews.apache.org/r/64737/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message