mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 64735: Fixed conversion warnings in tests.
Date Wed, 20 Dec 2017 03:43:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64735/
-----------------------------------------------------------

Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Repository: mesos


Description
-------

Fixed `double -> float` conversions. While the Protobuf type and literal
type are both `double`, the `FLOAT_EQ` tests were being used instead of
`DOUBLE_EQ`, causing a conversion warning.

Fixed `size_t` to `int` conversion warnings by casting.

Fixed warning for `Seconds(double)` as it takes `int64_t`. Can't change
the argument types because they're set in the protocol.


Diffs
-----

  src/tests/attributes_tests.cpp f053292e9185e9709d4da9c0b462541691772f1b 
  src/tests/protobuf_io_tests.cpp 4a2e3a3bc87c1a3394368439e5dd30b410e468a4 
  src/tests/resource_offers_tests.cpp 5564636dbabe25801a12b613a1cb04cd52ebb458 
  src/tests/resources_tests.cpp 64bde85e0e7f0bd395189eb6a8635383095b2f07 
  src/tests/resources_utils.cpp 9736c2a090250562704f2c874ce3872be68555ed 
  src/tests/scheduler_tests.cpp 87ef589fc296d01cfca8bf0b67390b097f68406b 
  src/tests/slave_tests.cpp b87015d4b3f3fcd1948978d42e20de8108e8f93a 
  src/tests/values_tests.cpp f7e6fa786b85460185dbf83572e5d282671ab519 


Diff: https://reviews.apache.org/r/64735/diff/1/


Testing
-------

These are in Mesos.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message