mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64450: Update docs to mention new '--reconfiguration_policy' flag.
Date Wed, 20 Dec 2017 11:27:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/#review194226
-----------------------------------------------------------


Fix it, then Ship it!





docs/agent-recovery.md
Lines 20-21 (original), 21-22 (patched)
<https://reviews.apache.org/r/64450/#comment272950>

    I know it's not you, but since you're touching this text, please fix it. If these are
protobuf messages names, write `TaskInfo` (mind backticks!), if it is English text, write
"task specification".



docs/agent-recovery.md
Lines 20-22 (original), 21-23 (patched)
<https://reviews.apache.org/r/64450/#comment272951>

    Why have you killed this paragraph? Maybe somehow combine it with the previous one?



docs/agent-recovery.md
Line 26 (original), 27 (patched)
<https://reviews.apache.org/r/64450/#comment272952>

    s/refuse/will refuse



docs/agent-recovery.md
Line 29 (original), 30 (patched)
<https://reviews.apache.org/r/64450/#comment272954>

    Let's explicitly mention here that the agent is allowed to recover its ID after a host
reboot. And it will fall back to wiping the state if the configuration is incompatible.



docs/agent-recovery.md
Line 31 (original), 32 (patched)
<https://reviews.apache.org/r/64450/#comment272953>

    s/register/will register



docs/agent-recovery.md
Line 40 (original), 39-43 (patched)
<https://reviews.apache.org/r/64450/#comment272955>

    Thank you for cleaning this up!



docs/agent-recovery.md
Lines 51-57 (original), 55-61 (patched)
<https://reviews.apache.org/r/64450/#comment272957>

    Any reason to remove this section in this RR?



docs/agent-recovery.md
Line 63 (original), 67 (patched)
<https://reviews.apache.org/r/64450/#comment272956>

    s/NOTE:/**NOTE:**



docs/configuration/agent.md
Lines 1055 (patched)
<https://reviews.apache.org/r/64450/#comment272948>

    Maybe "The old and the new state must match exactly"?



docs/configuration/agent.md
Lines 1057 (patched)
<https://reviews.apache.org/r/64450/#comment272946>

    \n" ?



docs/configuration/agent.md
Lines 1058 (patched)
<https://reviews.apache.org/r/64450/#comment272947>

    Maybe "to remove or to modify"?



docs/configuration/agent.md
Lines 1061 (patched)
<https://reviews.apache.org/r/64450/#comment272945>

    s/slave/agent



docs/configuration/agent.md
Lines 1062 (patched)
<https://reviews.apache.org/r/64450/#comment272949>

    s/which/which, e.g.,/


- Alexander Rukletsov


On Dec. 12, 2017, 11:16 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64450/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 11:16 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update docs to mention new  flag.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
>   docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
>   docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
> 
> 
> Diff: https://reviews.apache.org/r/64450/diff/1/
> 
> 
> Testing
> -------
> 
> One pass of proof-reading.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message