mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64069: Ensured command executor always honors shutdown request.
Date Wed, 20 Dec 2017 11:54:39 GMT


> On Dec. 19, 2017, 3:25 p.m., Andrei Budnik wrote:
> > src/launcher/executor.cpp
> > Lines 768 (patched)
> > <https://reviews.apache.org/r/64069/diff/1/?file=1901225#file1901225line768>
> >
> >     Let's print warning message before terminating:
> >     ```
> >     LOG(WARNING) << "Attempted to shutdown the executor with no running task";
> >     ```

I'm not sure we should. Shutdown is issued if, e.g., the scheduler exits, which — in contrast
to kill task — is not related to the task lifecycle.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64069/#review194147
-----------------------------------------------------------


On Dec. 15, 2017, 10:43 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64069/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 
> 
> 
> Diff: https://reviews.apache.org/r/64069/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/64033/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message