mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64069: Ensured command executor always honors shutdown request.
Date Wed, 20 Dec 2017 12:02:34 GMT


> On Dec. 18, 2017, 9:40 p.m., Vinod Kone wrote:
> > What about the fix for other built-in executors (docker, default)?
> > 
> > Also, this only seems to fix the shutdown path, what about kill task path?
> > 
> > 
> > Regaring the fix for kill task when a task hasn't been launched from the perspective
of the executor, I think doing a CHECK fail makes sense to me because there was violation
of an external variant (kill comes after launch). Silently shutting down in such a scenario
seems risky because it will mask the extent of the problem. Either way we need the system
to heal and correct itself when variants fail; right now the executor ignores the kill and
stays up which is a really bad UX. cc @anand

Other executors already behave correctly.
Docker: https://github.com/apache/mesos/blob/5f40f3d401bbdd7e324113214c286a26faf67540/src/docker/executor.cpp#L333
Default: https://github.com/apache/mesos/blob/5f40f3d401bbdd7e324113214c286a26faf67540/src/launcher/default_executor.cpp#L966

Kill task path is addressed here: https://reviews.apache.org/r/64033/

I completely agree with the sentiment about bad UX. I'm fine with doing the `CHECK`; let's
continue discussion in the aforementioned RR.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64069/#review194088
-----------------------------------------------------------


On Dec. 15, 2017, 10:43 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64069/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 
> 
> 
> Diff: https://reviews.apache.org/r/64069/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/64033/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message