mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64450: Update docs to mention new flag.
Date Wed, 20 Dec 2017 13:40:53 GMT


> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote:
> > docs/agent-recovery.md
> > Lines 20-22 (original), 21-23 (patched)
> > <https://reviews.apache.org/r/64450/diff/1/?file=1911497#file1911497line22>
> >
> >     Why have you killed this paragraph? Maybe somehow combine it with the previous
one?

It felt redundant, but I restored it now.


> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote:
> > docs/agent-recovery.md
> > Line 26 (original), 27 (patched)
> > <https://reviews.apache.org/r/64450/diff/1/?file=1911497#file1911497line28>
> >
> >     s/refuse/will refuse

Looks like both are correct: https://english.stackexchange.com/questions/63081/repeating-to-and-will-in-enumerations-of-verbs

I still went ahead and changed it.


> On Dec. 20, 2017, 11:27 a.m., Alexander Rukletsov wrote:
> > docs/agent-recovery.md
> > Lines 51-57 (original), 55-61 (patched)
> > <https://reviews.apache.org/r/64450/diff/1/?file=1911497#file1911497line58>
> >
> >     Any reason to remove this section in this RR?

It's a bit confusing to say that the `recover` option affects the slave recovery behaviour
when it has to be set to `reconnect` in order to be able to even talk about recovery (since
setting it to `cleanup` will just turn the `mesos-agent` into some cleanup binary that never
registers with the master or recovers anything)


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/#review194226
-----------------------------------------------------------


On Dec. 20, 2017, 1:26 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64450/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 1:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update docs to mention new  flag.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de 
>   docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36 
>   docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95 
>   src/slave/flags.cpp d4b95b7542733b22299bc19235cf99220534c022 
> 
> 
> Diff: https://reviews.apache.org/r/64450/diff/2/
> 
> 
> Testing
> -------
> 
> One pass of proof-reading.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message