mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64750: Fixed an agent assertion.
Date Wed, 20 Dec 2017 15:22:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64750/#review194250
-----------------------------------------------------------



PASS: Mesos patch 64750 was successfully built and tested.

Reviews applied: `['64750']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64750

- Mesos Reviewbot Windows


On Dec. 20, 2017, 2:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64750/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 2:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initially it was valid to assert that 'checkpointResources' would
> never be called for an agent with resource providers, but we have
> sinced moved to an implementation where we might perform checkpointing
> of agent resources (but never local resource provider resources).
> 
> This patch adjusts an assertion in the agent's 'checkpointResources'
> function to that reality.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 264705f9e8fc91407aae691dc9f6d4dc5048dfaa 
> 
> 
> Diff: https://reviews.apache.org/r/64750/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message