mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64003: Made quota resource allocation fine-grained.
Date Thu, 21 Dec 2017 01:16:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64003/#review194283
-----------------------------------------------------------



Tests look good, do we want to add a test to ensure unchoppable resources don't get chopped?


src/tests/hierarchical_allocator_tests.cpp
Line 3831 (original), 3834 (patched)
<https://reviews.apache.org/r/64003/#comment273023>

    Is this comment still accurate? More than its quota?



src/tests/hierarchical_allocator_tests.cpp
Lines 5198-5200 (original)
<https://reviews.apache.org/r/64003/#comment273026>

    Should we keep the content after the first comma?


- Benjamin Mahler


On Dec. 20, 2017, 2:06 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64003/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 2:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-7099
>     https://issues.apache.org/jira/browse/MESOS-7099
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allocator now does fine-grained resource allocation up
> to the role’s quota limit. And a role's quota is only
> considered to be satisfied if all of its quota resources
> are satisfied. Previously, a role's quota is considered
> to be met if any one of its quota resources reaches the limit.
> 
> Also fixed a few affected allocator tests.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 1c767f7f778819dcfa6eff51765163aec1b70a2d

>   src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2

> 
> 
> Diff: https://reviews.apache.org/r/64003/diff/4/
> 
> 
> Testing
> -------
> 
> Fixed a few broken tests due to this patch.
> make check.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message