mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 64770: Fixed a potential race condition in the test infrastructure.
Date Thu, 21 Dec 2017 15:58:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64770/
-----------------------------------------------------------

(Updated Dec. 21, 2017, 3:58 p.m.)


Review request for mesos, Alexander Rukletsov, Greg Mann, and Joseph Wu.


Bugs: MESOS-7506
    https://issues.apache.org/jira/browse/MESOS-7506


Repository: mesos


Description (updated)
-------

There was a race condition leading to flaky
`LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test.
This test launches successively multiple agents, while reusing the same
variable. After reassigning the value of the variable, agent's d'tor is
called. If agent recovery is not yet completed, then some orphaned
container might blink in the agent's d'tor as it is described in the
comment to the code.


Diffs
-----

  src/tests/cluster.cpp f964bf0cd0cf22374877e5748ba142dcb5fee133 


Diff: https://reviews.apache.org/r/64770/diff/1/


Testing
-------

sudo make check (fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message