mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65045: Tested correct operation handling during master failover.
Date Thu, 01 Feb 2018 06:56:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review196621
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 8772 (patched)
<https://reviews.apache.org/r/65045/#comment276316>

    Is this necessary?



src/tests/master_tests.cpp
Lines 8812 (patched)
<https://reviews.apache.org/r/65045/#comment276317>

    Is this necessary?



src/tests/master_tests.cpp
Lines 8893 (patched)
<https://reviews.apache.org/r/65045/#comment276318>

    Is this necessary?



src/tests/master_tests.cpp
Lines 8899 (patched)
<https://reviews.apache.org/r/65045/#comment276319>

    Is this necessary?



src/tests/master_tests.cpp
Lines 8903 (patched)
<https://reviews.apache.org/r/65045/#comment276320>

    Do we need this, or does framework registration after master failover prompt an offer?



src/tests/master_tests.cpp
Lines 8912-8914 (patched)
<https://reviews.apache.org/r/65045/#comment276321>

    Please put each condition on a separate line:
    ```
        if (resource.has_provider_id() &&
            resource.has_disk() &&
            resource.disk().has_source() &&
            resource.disk().source().type() == Resource::DiskInfo::Source::MOUNT) {
    ```


- Greg Mann


On Jan. 25, 2018, 1:10 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2018, 1:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
>     https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message