mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65403: Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.
Date Thu, 01 Feb 2018 23:23:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65403/
-----------------------------------------------------------

(Updated Feb. 1, 2018, 3:23 p.m.)


Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Summary (updated)
-----------------

Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.


Bugs: MESOS-5882
    https://issues.apache.org/jira/browse/MESOS-5882


Repository: mesos


Description (updated)
-------

Previously we mapped `O_CLOEXEC` to `O_NOINHERIT`, which is close to the
intended semantics, but not close enough. Instead, we want all Windows
handles by default to be non-inheritable, and not tie any Windows
inheritance semantics to the close-on-exec semantics. So, we define
`O_CLOEXEC` on Windows to be `0`, and remove the logging from the
`os::cloexec` family of functions because do not ever intend to
implement them.

We achieve the "close" part of the semantics by making all handles
non-inheritable, as the intent is to avoid leaking handles.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/open.hpp 6711f22d44b0e7c13da3abd51f9fb7b71779e868 
  3rdparty/stout/include/stout/os/windows/fcntl.hpp 5800ec92f85401a80cb813afd880be2e5a24a3af



Diff: https://reviews.apache.org/r/65403/diff/2/

Changes: https://reviews.apache.org/r/65403/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message