mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Review Request 65474: Updated socket shutdown to return SocketError.
Date Fri, 02 Feb 2018 05:50:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65474/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Benjamin Mahler.


Bugs: MESOS-8513
    https://issues.apache.org/jira/browse/MESOS-8513


Repository: mesos


Description
-------

Socket::shutdown returns SocketError allowing for higher level
functions to have more control over logging errors where needed.
Also switches SocketManager::close's shutdown failure logging
back to ERROR level as we are now able to filter out expected
failures.


Diffs
-----

  3rdparty/libprocess/include/process/socket.hpp ae6154d5d142f65352e00f37b4e66d0b62fdc3c2

  3rdparty/libprocess/src/http.cpp cc41fa6f671cf029a46722299eded1a27da210d3 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp 640fa676ef570f7fcf3f96249662837497a2c76c

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 521b0cfbccd3599524b1407ef70880f4538941df

  3rdparty/libprocess/src/process.cpp ba9bc291bb6741e32b3a066fe90771311d21852a 
  3rdparty/libprocess/src/tests/ssl_tests.cpp b1a0ea614d7483e683ac056cf822ce816221babb 


Diff: https://reviews.apache.org/r/65474/diff/1/


Testing
-------

make check, visual logging inspection


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message