mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.
Date Tue, 06 Feb 2018 03:38:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review196859
-----------------------------------------------------------



Very nice! A couple of questions:

(1) What is this going to show when the quota.guarantee is set? It should show that limit
is set to the same numbers, but FWICT this will continue to display None? Note that we don't
expose a limit field yet, so the UI shouldn't be trying to access one.

(2) I think we've generally showed '-' for unset fields to reduce the amount of visual cluster.
So s/None/-/ here would be more consistent and probably look a bit cleaner?

(3) Is it possible to show thicker vertical lines between the group columns to make the grouping
a bit clearer when looking further down the table?


src/webui/master/static/roles.html
Lines 46-49 (patched)
<https://reviews.apache.org/r/65346/#comment276737>

    I also wonder here if s/0/-/ would make the table cleaner. Even though no guarantee =
0, it also would help the user see when the guarantee is set to 0 vs it's 0 because it's unset.



src/webui/master/static/roles.html
Lines 51-54 (patched)
<https://reviews.apache.org/r/65346/#comment276736>

    We can't look at `limit` field yet, since it doesn't exist. Right now the limit is implicitly:
    
    (1) No guarantee: no limit, or
    (2) Some guarantee X: limit set to X.
    
    For each resource. Can you have the UI display it accordingly?
    
    Also, can we show "-" for these? I think that's been the general pattern in the UI for
"unset" things to reduce visual clutter.


- Benjamin Mahler


On Feb. 4, 2018, 9:18 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2018, 9:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.
> 
> 
> Bugs: MESOS-8486
>     https://issues.apache.org/jira/browse/MESOS-8486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e 
>   src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1 
>   src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622 
>   src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91 
> 
> 
> Diff: https://reviews.apache.org/r/65346/diff/2/
> 
> 
> Testing
> -------
> 
> New UI:
> ![New UI](https://i.imgur.com/rcSUP8N.png)
> The group columns cannot be ordered as they have sub-columns, this is expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message