mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65399: Windows: Moved "kill on close" job object flag to own function.
Date Wed, 07 Feb 2018 19:20:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65399/
-----------------------------------------------------------

(Updated Feb. 7, 2018, 11:20 a.m.)


Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Bugs: MESOS-6713
    https://issues.apache.org/jira/browse/MESOS-6713


Repository: mesos


Description
-------

Instead of setting this flag unconditionally when we create a job
object, this patch abstracts it to the the function
`set_job_kill_on_close_limit(pid_t)` so that users can choose how to tie
job object lifetimes together.


Diffs (updated)
-----

  3rdparty/stout/include/stout/windows/os.hpp ec935209fc1532ebe087ac20933c99eed393506d 


Diff: https://reviews.apache.org/r/65399/diff/2/

Changes: https://reviews.apache.org/r/65399/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message