mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 65593: Added a test to ensure master removes fail-launched deafult executor.
Date Mon, 12 Feb 2018 19:48:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197300
-----------------------------------------------------------


Fix it, then Ship it!




Description: s/fail-launched deafult/default executor that failed to launch/


src/tests/slave_tests.cpp
Lines 4733 (patched)
<https://reviews.apache.org/r/65593/#comment277431>

    s/unscheule/unschedule/
    s/.So that/and that/


- Vinod Kone


On Feb. 10, 2018, 12:36 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2018, 12:36 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
>     https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unscheule GC failure. So that
> master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message