mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.
Date Mon, 12 Feb 2018 20:13:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65550/#review197304
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Line 349 (original), 349 (patched)
<https://reviews.apache.org/r/65550/#comment277450>

    Not yours, but I think we can kill this. I think this was added pre multiple task groups
support. We should be able to look into the `containers` map AFAICT.



src/launcher/default_executor.cpp
Line 647 (original), 642 (patched)
<https://reviews.apache.org/r/65550/#comment277448>

    Can you log that we are skipping wait in an `else` statement.



src/launcher/default_executor.cpp
Line 651 (original), 647 (patched)
<https://reviews.apache.org/r/65550/#comment277449>

    Can you log here because this gets called from couple different sites?


- Vinod Kone


On Feb. 10, 2018, 6:35 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65550/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2018, 6:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8468
>     https://issues.apache.org/jira/browse/MESOS-8468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor would unnecessarily shutdown if, while launching a
> task group, it gets unsubscribed after having successfully launched the
> task group's containers.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea 
> 
> 
> Diff: https://reviews.apache.org/r/65550/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message