mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 65624: Added fetcher tests for `stderr` output.
Date Tue, 13 Feb 2018 04:41:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65624/
-----------------------------------------------------------

Review request for mesos, Akash Gupta and Joseph Wu.


Repository: mesos


Description
-------

The fetcher is supposed to log its `stderr` output to a redirected file
called `stderr` in the given sandbox directory. There previously existed
a bug on Windows due to incorrect handle inheritance where this
redirection failed silently, leaving the log empty. These unit tests
assert that the correct content is logged to the `stderr` file for both
a success and failure fetch scenario.


Diffs
-----

  src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f 


Diff: https://reviews.apache.org/r/65624/diff/1/


Testing
-------

Windows (Linux pending):
```
[ RUN      ] FetcherTest.LogSuccessToStderr
[       OK ] FetcherTest.LogSuccessToStderr (197 ms)
[ RUN      ] FetcherTest.LogFailureToStderr
[       OK ] FetcherTest.LogFailureToStderr (320 ms)
```


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message