mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 65656: Removed unnecessary compiler flag in build instructions.
Date Thu, 15 Feb 2018 13:16:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/#review197615
-----------------------------------------------------------


Fix it, then Ship it!





docs/building.md
Line 103 (original), 103 (patched)
<https://reviews.apache.org/r/65656/#comment277831>

    While I think the ghist is entirely right - it is not accurate. 
    What about 's/to ignore them/to not escalate them to errors/'?


- Till Toenshoff


On Feb. 14, 2018, 5:01 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65656/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2018, 5:01 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After the recent upgrade to the bundled boost version, it
> is not necessary anymore to add `-Wno-deprecated-declaration`
> to the compiler flags.
> 
> Since users of Mesos shouldn't be expected to fix warnings in
> our code, a reference to the `--disable-werror` configure flag
> was also provided to allow easily ignoring compiler warnings.
> 
> 
> Diffs
> -----
> 
>   docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15 
> 
> 
> Diff: https://reviews.apache.org/r/65656/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message