mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.
Date Thu, 15 Feb 2018 14:54:21 GMT


> On Feb. 13, 2018, 10:52 a.m., Jan Schlicht wrote:
> > src/common/protobuf_utils.cpp
> > Line 467 (original), 467 (patched)
> > <https://reviews.apache.org/r/65588/diff/1/?file=1955477#file1955477line467>
> >
> >     How about we create a helper function `mesos::UUID createRandomUUID()` in `protobuf_utils`
even if that function would be almost trivial? This would allow us to have the expectations
of a UUID (i.e. it's `UUID::random().toBytes()`, not `UUID::random().toString()`) in a single
place.
> >     
> >     Here and below, where `->set_value(id::UUID::random().toBytes())` is used.

Good idea, I created a function `mesos::UUID createUUID(const Option<id::UUID>&
= None())` in https://reviews.apache.org/r/65674/ performing this work.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65588/#review197394
-----------------------------------------------------------


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65588/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
>     https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used proto UUID instead stout UUID internally for operation IDs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto e96a40493c351a7242465c8591cae981abc92f24

>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 
>   src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/message.hpp 2511af611edc94e3e3a78fce475bc8cd85ffc3f9 
>   src/slave/slave.hpp 42c3ebcf52b608e40e26ca85f5efb054dad2d2a1 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
> 
> 
> Diff: https://reviews.apache.org/r/65588/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message