mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 65591: Explicitly tracked resource providers in master.
Date Fri, 16 Feb 2018 01:13:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65591/#review197652
-----------------------------------------------------------




src/master/master.hpp
Lines 279-290 (patched)
<https://reviews.apache.org/r/65591/#comment277878>

    This looks strange.
    
    You probably want to remove these lines.



src/master/master.cpp
Line 7307 (original), 7351 (patched)
<https://reviews.apache.org/r/65591/#comment277881>

    Do we plan to support resource providers with info (so not the agent-default resources),
but without an ID?
    
    Line 7470 indicates that we don't.



src/master/master.cpp
Line 7488 (original), 7427-7428 (patched)
<https://reviews.apache.org/r/65591/#comment277883>

    Fix indentation.



src/master/master.cpp
Lines 7516 (patched)
<https://reviews.apache.org/r/65591/#comment277888>

    It doesnt look like `operation_` is used after this line. Can we revert to inlining the
creation of the operation?


- Gaston Kleiman


On Feb. 15, 2018, 6:54 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65591/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2018, 6:54 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
>     https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds explicit tracking of resource providers to the master
> process. While we already had explicitly send resource provider
> information in e.g., `UpdateSlaveMessage`, we only stored that
> information aggregated over the full agent in the master up to now.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 
>   src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 
> 
> 
> Diff: https://reviews.apache.org/r/65591/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message