mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 65679: Removed direct unmock calls and added missing mock call expectations.
Date Fri, 16 Feb 2018 01:22:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65679/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Repository: mesos


Description
-------

Directly invoking unmock calls in the test process can potentially
cause races with the real mock slave process. It is more robust to
dispatch the unmock calls to the real mock slave process.

Also added several mock expectations to avoid "uninteresting mock
call" test warnings.


Diffs
-----

  src/tests/slave_tests.cpp d2c242eae3169bff3b77770197a36f171cd668ba 


Diff: https://reviews.apache.org/r/65679/diff/1/


Testing
-------

`./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 --gtest_break_on_failure`
runs forever :)


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message