mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.
Date Fri, 16 Feb 2018 03:03:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65679/#review197656
-----------------------------------------------------------



PASS: Mesos patch 65679 was successfully built and tested.

Reviews applied: `['65679']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65679

- Mesos Reviewbot Windows


On Feb. 16, 2018, 1:22 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65679/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2018, 1:22 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Directly invoking unmock calls in the test process can potentially
> cause races with the real mock slave process. It is more robust to
> dispatch the unmock calls to the real mock slave process.
> 
> Also added several mock expectations to avoid "uninteresting mock
> call" test warnings.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b77770197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65679/diff/1/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 --gtest_break_on_failure`
runs forever :)
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message