mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.
Date Fri, 16 Feb 2018 15:07:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65044/#review197672
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/http.cpp
Lines 1695 (patched)
<https://reviews.apache.org/r/65044/#comment277906>

    We could make this `const`.



src/tests/api_tests.cpp
Lines 1061 (patched)
<https://reviews.apache.org/r/65044/#comment277909>

    We don't necessarily need to use the same content type for the RP as we do for the request
(we more care about the latter). Still seems like a good approach to me to increase coverage.



src/tests/api_tests.cpp
Lines 1135-1142 (patched)
<https://reviews.apache.org/r/65044/#comment277907>

    Let's also check here that `agent_id` matches what we expect. We should already have it
from e.g., `updateSlaveMessage` above.



src/tests/api_tests.cpp
Lines 6643-6651 (patched)
<https://reviews.apache.org/r/65044/#comment277908>

    Ditto.


- Benjamin Bannier


On Feb. 15, 2018, 11:19 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65044/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2018, 11:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-8424
>     https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The 'GET_OPERATIONS' call lists all operations known to master or agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c 
>   include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd 
>   include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a 
>   include/mesos/v1/master/master.proto 6759c3004e7e04c0044360b0c54f4438c2f6ec8a 
>   src/master/http.cpp 46f2872a17215464de2e4990e9cfcb3bff46812a 
>   src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 
>   src/master/validation.cpp 42f767e4269abe3f160fc7d97eb4522d1bee8e95 
>   src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 
>   src/slave/http.cpp 59eef7a4c90490a6dbcc09153494c200ed1d1b53 
>   src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 
>   src/tests/api_tests.cpp b042201bf07428bfc0007a713b98bf15d15470e1 
> 
> 
> Diff: https://reviews.apache.org/r/65044/diff/11/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message