mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65045: Tested correct operation handling during master failover.
Date Fri, 16 Feb 2018 15:14:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197674
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 8803 (patched)
<https://reviews.apache.org/r/65045/#comment277910>

    nit: Let's wrap this like other multi-line function calls you added above.



src/tests/master_tests.cpp
Lines 8812 (patched)
<https://reviews.apache.org/r/65045/#comment277911>

    Let's add a comment here why we expect to registrations; readers don't have that context,
yet.



src/tests/master_tests.cpp
Lines 8823 (patched)
<https://reviews.apache.org/r/65045/#comment277912>

    Make this a `const` ref.



src/tests/master_tests.cpp
Lines 8869 (patched)
<https://reviews.apache.org/r/65045/#comment277913>

    `const` ref.



src/tests/master_tests.cpp
Lines 8930 (patched)
<https://reviews.apache.org/r/65045/#comment277914>

    `const` ref



src/tests/master_tests.cpp
Lines 8934-8936 (patched)
<https://reviews.apache.org/r/65045/#comment277915>

    We could also check here that this is the same operation (identical ID) which was pending
above.


- Benjamin Bannier


On Feb. 7, 2018, 11:57 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 11:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
>     https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/8/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message