mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 65343: Adopted `TEST_AWAIT_TIMEOUT` in libprocess tests.
Date Fri, 16 Feb 2018 18:06:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65343/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 6:06 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Summary (updated)
-----------------

Adopted `TEST_AWAIT_TIMEOUT` in libprocess tests.


Bugs: MESOS-7016
    https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description (updated)
-------

Rather than hard-coding a 15sec test timeout, use the libprocess
`TEST_AWAIT_TIMEOUT` variable so that this can be globally tuned.
Added a test flag `--test_await_timeout` that can be used to set
the `TEST_AWAIT_TIMEOUT` on a test run.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/main.cpp 4633bea4caad3ddda809b7b5aa0c5220f8ad82c2 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 8211ae63e75359705af2bb9ac02a7cbdb28e3252



Diff: https://reviews.apache.org/r/65343/diff/5/

Changes: https://reviews.apache.org/r/65343/diff/4-5/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message