mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 65298: Split test flags into header and source files.
Date Fri, 16 Feb 2018 18:07:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65298/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 6:07 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Bugs: MESOS-7016
    https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description
-------

Split the test flags into header and source files to reduce the amount
of recompilation necessary when the implementation changes.


Diffs (updated)
-----

  src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
  src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 


Diff: https://reviews.apache.org/r/65298/diff/7/

Changes: https://reviews.apache.org/r/65298/diff/6-7/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message