mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Review Request 65692: Changed the signature of a DefaultExecutor kill method.
Date Sat, 17 Feb 2018 00:24:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65692/
-----------------------------------------------------------

Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8530
    https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
-------

This method is being passed the container to be killed as
`Owned<Container>`.

The container object is owned by the executor and stored in
`LinkedHashMap<TaskID, Owner<Container>> containers`.

We should pass around raw pointers and not make copies of the stored
`Owned` object, so this patch changes the signature of the `kill`
method.


Diffs
-----

  src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 


Diff: https://reviews.apache.org/r/65692/diff/1/


Testing
-------

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message