mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65696: Allowed base64-decoding with whitespaces.
Date Sat, 17 Feb 2018 08:40:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/#review197712
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65696]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 17, 2018, 8:27 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65696/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2018, 8:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Till Toenshoff.
> 
> 
> Bugs: MESOS-8569
>     https://issues.apache.org/jira/browse/MESOS-8569
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Most base64 decoders do not fail on encountering whitespace characters
> as several encoders embed newlines to enforce line-width in encoded
> data.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f 
>   3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66 
> 
> 
> Diff: https://reviews.apache.org/r/65696/diff/1/
> 
> 
> Testing
> -------
> 
> Updated base64 tests and ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message