mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 64608: Reverted unintended edit to cpplint.py.
Date Tue, 20 Feb 2018 09:10:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64608/#review197766
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Schlicht


On Feb. 20, 2018, 10:08 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64608/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2018, 10:08 a.m.)
> 
> 
> Review request for mesos, Gaojin CAO, Michael Park, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In 'bea8c3c9' we replaced '> >' with '>>' in C++ templates in a sweep
> across the codebase. We also unintentionally modified a comment in
> 'cpplint.py' which was e.g., not reflected in its patch file and also
> lead to no functional changes.
> 
> This patch reverts this modification to 'cpplint.py'.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
> 
> 
> Diff: https://reviews.apache.org/r/64608/diff/1/
> 
> 
> Testing
> -------
> 
> `./support/mesos-style.py 3rdparty/stout/tests/none_tests.cpp`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message