mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.
Date Tue, 20 Feb 2018 19:31:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.


Bugs: MESOS-8599
    https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description
-------

Only the Visual Studio generator(s) should check the toolset. The
Ninja generator requires the environment to be setup in advance, and
does not have the concept of a toolset, so this warning broke the
Ninja build.


Diffs
-----

  cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 


Diff: https://reviews.apache.org/r/65719/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message