mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 65720: Windows: Fixed location of imported libraries for Ninja.
Date Tue, 20 Feb 2018 19:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.


Bugs: MESOS-8599
    https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description
-------

The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), so we replace this
assumption with a pair of variables `CONFIG_DEBGUG` and
`CONFIG_RELEASE` which are correct for each generator. This is
somewhat ugly, but it's the cost of supporting multiple toolsets.


Diffs
-----

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 


Diff: https://reviews.apache.org/r/65720/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message