mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.
Date Tue, 20 Feb 2018 20:06:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review197801
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65503, 65346]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 4, 2018, 1:18 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2018, 1:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till
Toenshoff.
> 
> 
> Bugs: MESOS-8486
>     https://issues.apache.org/jira/browse/MESOS-8486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e 
>   src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1 
>   src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622 
>   src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91 
> 
> 
> Diff: https://reviews.apache.org/r/65346/diff/2/
> 
> 
> Testing
> -------
> 
> New UI:
> ![New UI](https://i.imgur.com/rcSUP8N.png)
> The group columns cannot be ordered as they have sub-columns, this is expected.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message