mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65721: Windows: Specified byproducts of `sasl2` imported target.
Date Wed, 21 Feb 2018 03:21:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65721/#review197838
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65719, 65720, 65721]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 20, 2018, 7:34 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65721/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2018, 7:34 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-8599
>     https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is necessary to enable the Ninja build. This was not previously
> fixed because we have not yet used Ninja on Windows. The same pattern
> is used for other imported targets.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65721/diff/1/
> 
> 
> Testing
> -------
> 
> Built with Ninja on Windows in 17 minutes, versus 21 minutes using the VS generator (both
builds completely from scratch).
> 
> Note that this isn't perfect; Ninja generates some warnings because the imported libraries
have both debug and release configurations pointing to the same location. We can ignore this
for now, as the build works, but it's ugly.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message